From: Gianni Tedesco <gianni.tedesco@citrix.com>
Date: Fri, 10 Sep 2010 17:47:53 +0000 (+0100)
Subject: xl: fix double free of domain names
X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~11516
X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/%22bookmarks://%22Dat/%22http:/www.example.com/cgi/%22https:/%22bookmarks:/%22Dat?a=commitdiff_plain;h=8ec7facba387ad9daddda55949332aa8afebf2f1;p=xen.git

xl: fix double free of domain names

Assigning malloc'd variables from one structure to another when both of
them are free'd via destructors is a bad idea. Let's use a strdup.

Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com>
---

diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index c8df350be9..d92e288ede 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -296,7 +296,7 @@ static void init_dm_info(libxl_device_model_info *dm_info,
 
     libxl_uuid_generate(&dm_info->uuid);
 
-    dm_info->dom_name = c_info->name;
+    dm_info->dom_name = strdup(c_info->name);
     dm_info->device_model = strdup("qemu-dm");
     dm_info->videoram = b_info->video_memkb / 1024;
     dm_info->apic = b_info->u.hvm.apic;